New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ByteArray.hx #1475

Merged

RobDangerous merged 1 commit into Kode:main from Onek8:main

Oct 10, 2023

Contributor

Onek8 commented Oct 10, 2023

Fix hashlink warning for cast to Int pointed out by Zeta

On HL ByteArray.getUInt32 returns a hl.I64 for some reason:

Kha/Backends/Kinc-HL/kha/arrays/ByteArray.hx

Line 73 in 9585c2b

public inline function getUint32(byteOffset: Int): hl.I64 {

But then it's turned into an Int here:

Kha/Sources/kha/arrays/Uint32Array.hx

Line 16 in 9585c2b

public inline function get(k: Int): Int {

, which leads to that new warning.


          Update ByteArray.hx

1f023e5

Fix hashlink warning for cast to Int pointed out by Zeta

On HL ByteArray.getUInt32 returns a hl.I64 for some reason: <https://github.com/Kode/Kha/blob/9585c2ba99683734dc2421ac31252c2a7e7e7153/Backends/Kinc-HL/kha/arrays/ByteArray.hx#L73>
But then it's turned into an Int here: <https://github.com/Kode/Kha/blob/9585c2ba99683734dc2421ac31252c2a7e7e7153/Sources/kha/arrays/Uint32Array.hx#L16>, which leads to that new warning.

Member

RobDangerous commented Oct 10, 2023

But this is wrong, this should be fixed in HL.

Member

RobDangerous commented Oct 10, 2023

Aaah, no, I misinterpreted "HL's ByteArray". Allrighty then.

RobDangerous merged commit 2414a9e into Kode:main

23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet