Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_dual function #29

Merged
merged 2 commits into from
Sep 8, 2024
Merged

remove_dual function #29

merged 2 commits into from
Sep 8, 2024

Conversation

KnutAM
Copy link
Owner

@KnutAM KnutAM commented Sep 7, 2024

ForwardDiff.value, and especially Tensors._extract_value, are not exported / public API.
(Note Ferrite-FEM/Tensors.jl#208 that proposes to make Tensors.extract_value a public function).

Instead of recommending users of FerriteAssembly to use these, it is better to provide a function for common input types (Numbers and AbstractTensors)

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (61d9a88) to head (cd8a834).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   98.76%   97.68%   -1.08%     
==========================================
  Files          28       29       +1     
  Lines         970      994      +24     
==========================================
+ Hits          958      971      +13     
- Misses         12       23      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnutAM KnutAM merged commit 9e8c2d3 into main Sep 8, 2024
10 of 11 checks passed
@KnutAM KnutAM deleted the dual_utils branch September 8, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant