Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE4 and Unity can now capture using WebRTC. (without Godot) #96

Merged
merged 23 commits into from
Mar 8, 2024

Conversation

KirisameMarisa
Copy link
Owner

No description provided.

* websocket-sharp
* add submodule websocket-sharp
* websocket-sharp Add to ignore list
* web socket added reconnection process
* RTCMessage added the playerid filed. (because it matches the UnrealEngine structure type.
** When the movie frame received, write directly to the movie file
** Delete old movie files when the maximum number of movie frames is reached
** IssueAssetCollector is simpler, it only receives movie file path
target platform of client changed from any cpu to x64 because of opencvsharp4 requires x64.
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 29.98%. Comparing base (d5f1cae) to head (42840eb).

Files Patch % Lines
...IssueAssetCollector/Handlers/Movie/MovieHandler.cs 0.00% 22 Missing ⚠️
...ssueAssetCollector/Handlers/CreateActionHandler.cs 0.00% 8 Missing ⚠️
Application/Models/Config/Parts/CaptureSetting.cs 0.00% 5 Missing ⚠️
Application/Models/Config/Configs/UserConfig.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   30.29%   29.98%   -0.31%     
==========================================
  Files          99      102       +3     
  Lines        2862     2898      +36     
  Branches      388      389       +1     
==========================================
+ Hits          867      869       +2     
- Misses       1940     1974      +34     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KirisameMarisa KirisameMarisa changed the title [WIP] UE4 and Unity can now capture using WebRTC. (without Godot) UE4 and Unity can now capture using WebRTC. (without Godot) Mar 8, 2024
@KirisameMarisa KirisameMarisa merged commit fa75827 into master Mar 8, 2024
5 of 6 checks passed
@KirisameMarisa KirisameMarisa deleted the web-rtc branch March 8, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants