Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for multi-arena episodes #51

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

benaslater
Copy link
Contributor

Proposed change(s)

This change adds a bit of documentation for the multi-episode arenas feature I've been working on. Arguably we should save this until that feature is merged an released, but getting the documentation PR done so we don't forget it.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • [N/A] Added tests that prove my fix is effective or that my feature works
  • [N/A] Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • [N/A] Updated the migration guide (if applicable)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOORAH! You submitted your first pull review! We hope it's one of the many to come! Thank you so much in taking the time, energy and commitment to making Animal-AI better!

@alhasacademy96
Copy link
Member

Looks great Ben :)

Q: have you updated the other sections of the docs, where applicable, such as CHANGELOG.MD? For the sake of not forgetting any docs to update, perhaps it's better to update all other docs in this PR?

@benaslater

Copy link
Member

@alhasacademy96 alhasacademy96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments Ben :)

@@ -557,6 +557,50 @@ We can observe that:
* Additionally, if we set `blackouts` to `[-20]`, the arena will blackout every 20 frames (because we placed the '-' indicating repeat).
* The blackout has no effect on any other aspect of the agent or the arena. For example, the agent will still be able to move around the arena, and the objects in the arena will still be visible to the agent. _RayCasting_ will still work.

#### EXAMPLE 8 - Multi-Arena Episodes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also update the TOC to add this new section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially stupid question - what is TOC?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table of contents in the md file :).

!ArenaConfig
arenas:
0: !Arena
t: 50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that "t" and "pass_mark" will be renamed to "timeLimit" and "passMark" respectively. This is for all AAI builds from v.4.1.0 and up.

For the sake of brevity, could you replace these to their newer names?

docs/configGuide/YAML-Config-Syntax.md Outdated Show resolved Hide resolved
@benaslater
Copy link
Contributor Author

Looks great Ben :)

Q: have you updated the other sections of the docs, where applicable, such as CHANGELOG.MD? For the sake of not forgetting any docs to update, perhaps it's better to update all other docs in this PR?

@benaslater

Sorry, I forgot about CHANGELOG.md. I can make a revision to this to update it - are there any other files in the docs you think would need updating?

@alhasacademy96
Copy link
Member

Perhaps you could update the changelog as a draft or remind me when the next build is to be released so I add your changes to the log, but for now, it's not important. I just wanted to ask if you considered the changelog.md in this PR.

I think as a general feedback you should aim to push the tech PR first and then push the docs on the docs, so its still fresh in your mind and you don't have to go back to the docs PR if changes are made in the tech PR. :)

Copy link

Multi-Arena Episodes

1 similar comment
Copy link

Multi-Arena Episodes

Copy link
Member

@alhasacademy96 alhasacademy96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good to go

@alhasacademy96 alhasacademy96 merged commit 645d2c7 into main Apr 19, 2024
1 check passed
@alhasacademy96 alhasacademy96 deleted the multiEpisodeArenaDocs branch April 19, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants