Add missing swapchain maintenance validation #9107
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 333769. |
|
CI Vulkan-ValidationLayers build # 18467 running. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
772e5c7 to
e26b410
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 333786. |
|
CI Vulkan-ValidationLayers build # 18468 running. |
|
CI Vulkan-ValidationLayers build # 18468 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
e26b410 to
a55ca57
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 336756. |
|
CI Vulkan-ValidationLayers build # 18499 running. |
|
CI Vulkan-ValidationLayers build # 18499 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
a55ca57 to
db2e303
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 336815. |
|
CI Vulkan-ValidationLayers build # 18502 running. |
|
CI Vulkan-ValidationLayers build # 18502 failed. |
|
@ziga-lunarg rebase and I will look into CI failures (don't want these to go stale) |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
db2e303 to
6af1fdc
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 343529. |
|
CI Vulkan-ValidationLayers build # 18621 running. |
|
CI Vulkan-ValidationLayers build # 18621 failed. |
| @@ -1875,6 +1875,7 @@ TEST_F(NegativeWsi, SwapchainMaintenance1ExtensionAcquire) { | |||
| AddRequiredExtensions(VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME); | |||
| AddRequiredExtensions(VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME); | |||
| AddSurfaceExtension(); | |||
| AddRequiredFeature(vkt::Feature::swapchainMaintenance1); | |||
There was a problem hiding this comment.
this is needed for PositiveWsi.CreateSwapchainWithPresentModeInfo and PositiveWsi.PresentFenceWaitsForSubmission
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
6af1fdc to
a1cf254
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 343638. |
|
CI Vulkan-ValidationLayers build # 18626 running. |
|
CI Vulkan-ValidationLayers build # 18626 aborted. |
| @@ -1351,6 +1352,7 @@ TEST_F(PositiveWsi, PresentFenceWaitsForSubmission) { | |||
| AddSurfaceExtension(); | |||
| AddRequiredExtensions(VK_EXT_SURFACE_MAINTENANCE_1_EXTENSION_NAME); | |||
| AddRequiredExtensions(VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME); | |||
| AddRequiredFeature(vkt::Feature::swapchainMaintenance1); | |||
There was a problem hiding this comment.
PresentFenceRetiresPresentQueueOperation also needs this
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
a1cf254 to
2fc93e4
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 345507. |
|
CI Vulkan-ValidationLayers build # 18665 running. |
|
CI Vulkan-ValidationLayers build # 18665 failed. |
| TEST_F(NegativeWsi, PresentInfoSwapchainsDifferentPresentModes) { | ||
| TEST_DESCRIPTION("Submit VkPresentInfo where one swapchain has VkSwapchainPresentModesCreateInfoEXT and the other does not"); | ||
|
|
||
| AddRequiredExtensions(VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME); |
There was a problem hiding this comment.
looking at CI, the logic in AddRequiredExtensions(VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME); should automatically include VK_KHR_get_physical_device_properties2 but the call under is using vkGetPhysicalDeviceFeatures2
I think the simple fix is just for anything it using Swapchain Maintenance 1 to just include SetTargetApiVersion(VK_API_VERSION_1_1); with it to not hit this issue (there is no way a 1.0 device is going to try and ship this extension)
Closes #9099