Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extension from OpDecorateId #455

Closed
wants to merge 1 commit into from

Conversation

Naghasan
Copy link
Member

OpDecorateId was introduced by SPIR-V 1.2 not by SPV_GOOGLE_hlsl_functionality1

OpDecorateId was introduced by SPIR-V 1.2 not by SPV_GOOGLE_hlsl_functionality1

Signed-off-by: Victor Lomuller <[email protected]>
@bashbaug
Copy link
Contributor

It might be both SPIR-V 1.2 and SPV_GOOGLE_hlsl_functionality1. See:
https://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/GOOGLE/SPV_GOOGLE_hlsl_functionality1.html

In the OpDecorateId instruction’s Capability box, remove the statement "Missing before version 1.2", to allow this instruction to be used with this extension. Also, in the description of the OpDecorateId instruction, change "All such Extra Operands must be constant instructions." to "All such Extra Operands must be constant instructions or the result of OpVariable instructions.

@Naghasan
Copy link
Member Author

true the extension enables it outside 1.2, I made the shortcut of "adds" rather than "enables"

@Naghasan Naghasan closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants