Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spirv generator info #445

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

kuhar
Copy link
Contributor

@kuhar kuhar commented Aug 21, 2024

  • List LLVM as the vendor for MLIR and update the contact info
  • Update the spiregg maintainer (Steven)

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
All committers have signed the CLA.

@kuhar
Copy link
Contributor Author

kuhar commented Aug 21, 2024

cc: @antiagainst @dneto0

@kuhar
Copy link
Contributor Author

kuhar commented Aug 22, 2024

cc: @Naghasan @bashbaug @alan-baker for code review (I don't have commit access and can't request directly)

<id value="15" vendor="Google" tool="rspirv" comment="Contact Lei Zhang, [email protected]"/>
<id value="16" vendor="X-LEGEND" tool="Mesa-IR/SPIR-V Translator" comment="Contact Metora Wang, github:metora/MesaGLSLCompiler"/>
<id value="17" vendor="Khronos" tool="SPIR-V Tools Linker" comment="Contact David Neto, [email protected]"/>
<id value="18" vendor="Wine" tool="VKD3D Shader Compiler" comment="Contact [email protected]"/>
<id value="19" vendor="Tellusim" tool="Clay Shader Compiler" comment="Contact [email protected]"/>
<id value="20" vendor="W3C WebGPU Group" tool="WHLSL Shader Translator" comment="https://github.com/gpuweb/WHLSL"/>
<id value="21" vendor="Google" tool="Clspv" comment="Contact David Neto, [email protected]"/>
<id value="22" vendor="Google" tool="MLIR SPIR-V Serializer" comment="Contact Lei Zhang, antiagainst@google.com"/>
<id value="22" vendor="LLVM" tool="MLIR SPIR-V Serializer" comment="Contact Jakub Kuderski, jakub.kuderski@amd.com, https://mlir.llvm.org/docs/Dialects/SPIR-V/"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one LGTM

include/spirv/spir-v.xml Outdated Show resolved Hide resolved
@kuhar kuhar requested a review from dneto0 August 22, 2024 19:46
@kuhar
Copy link
Contributor Author

kuhar commented Aug 27, 2024

ping for review @dneto0

I don't have commit access to this repo, could you merge it for me once the PR gets approved?

@bashbaug
Copy link
Contributor

Merging as discussed in the August 28th teleconference.

@bashbaug bashbaug merged commit 744753a into KhronosGroup:main Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants