Headers support for SPV_INTEL_maximum_registers extension #416
Conversation
| "enumerant" : "NamedMaximumRegistersINTEL", | ||
| "value" : 6463, | ||
| "parameters" : [ | ||
| { "kind" : "LiteralInteger", "name" : "'Named Maximum Number of Registers'" } |
There was a problem hiding this comment.
Question goes to @bashbaug , with the spelling from KhronosGroup/SPIRV-Registry#235 "kind" : "LiteralInteger" seems to be correct. But I have a feeling, that intention here should be to change kind to "kind" : "NamedMaximumNumberofRegisters" binding the parameter with possible values to be used by validator. So, should we adjust the spec a bit for this? Not sure if I have enough understanding, when we should spell out possible values for a literal parameter.
There was a problem hiding this comment.
Good catch - I do think this would make validation easier, and the disassembled SPIR-V might be a little nicer also.
Can you have a look at my suggested change on the spec PR to be sure this is what you're thinking of?
KhronosGroup/SPIRV-Registry#235 (comment)
Let me know if you need help with any other tooling, also.
There was a problem hiding this comment.
I accepted the spec suggestion. Let's go with the "NamedMaximumNumberOfRegisters" "kind". Thanks!
There was a problem hiding this comment.
Create a PR to Tools to support operand kind there too: KhronosGroup/SPIRV-Tools#5580
|
Merging as discussed in the February 28th teleconference. |
…up#416) * Headers support for SPV_INTEL_maximum_registers extension * Use an operand kind for the named maximum number of registers * apply CI suggestions
Spec: KhronosGroup/SPIRV-Registry#235