Fix -Wcast-qual warnings #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast pointers to the correct type to avoid -Wcast-qual warnings
|
|
bashbaug
approved these changes
Oct 25, 2024
| @@ -9392,9 +9392,9 @@ class CommandQueue : public detail::Wrapper<cl_command_queue> | |||
| object_, userFptr, args.first, args.second, | |||
| (mem_objects != nullptr) ? (cl_uint) mem_objects->size() : 0, | |||
| (mem_objects->size() > 0 ) ? reinterpret_cast<const cl_mem *>(mem_objects->data()) : nullptr, | |||
| (mem_locs != nullptr && mem_locs->size() > 0) ? (const void **) &mem_locs->front() : nullptr, | |||
| (mem_locs != nullptr && mem_locs->size() > 0) ? const_cast<const void**>(&mem_locs->front()) : nullptr, | |||
There was a problem hiding this comment.
Needing to use const_cast here is unfortunate, but I don't think there is any way to avoid it.
Linking with KhronosGroup/OpenCL-Docs#9 for completeness.
|
Merging as discussed in the October 29th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast pointers to the correct type to avoid -Wcast-qual warnings