disable use of stdext::checked_array_iterator for VS2019 and newer #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasMagnus
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Checked back to VS 2015. 2015 (toolset v140) issues a false warning on /W4, but we can't fix that. (I argues about an unreferenced formal parameter to a function, but the parameter is totally used. No ifdefs, no control flow...) This change however seems fine. Toolsets v141, v142, v143 all pass warning free.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #293.
It seems that the use of
stdext::checked_array_iteratoris not required for VS2019 and newer. So, add_MSC_VERchecks to fall back to the generic version for newer versions of Visual Studio.