Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing definitions for deprecated prefixes and suffixes for ve… #159

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

pkeir
Copy link
Contributor

@pkeir pkeir commented Nov 7, 2021

…rsion 2.2. This will resolve issue #158 .

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Should we create an issue to add similar blocks for the 1.0, 2.0, and 2.1 deprecation defines? They aren't currently used as far as I can see, but this could prevent a similar bug in the future.

@pkeir
Copy link
Contributor Author

pkeir commented Nov 8, 2021

No problem. Yes, I would say so, for the reason you mention. In each future release it might become an almost mechanical addition.

@bashbaug
Copy link
Contributor

I created #161 to track definitions for the other OpenCL versions. Merging - thank you again!

@bashbaug bashbaug merged commit 25ad589 into KhronosGroup:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants