Add optional support for VkPhysicalDeviceFeatures::wideLines. #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2024
Closed
spnda
requested changes
Jan 25, 2024
- Add MVK_USE_METAL_PRIVATE_API build setting to allow MoltenVK to be built with access to Metal private API calls. - Add support for VkPhysicalDeviceFeatures::wideLines feature when MVK_USE_METAL_PRIVATE_API is enabled in a MoltenVK build. - Set lineWidthRange and lineWidthGranularity to reasonable arbitrary values.
billhollings
force-pushed
the
private-widelines
branch
from
4a20140 to
5992dda
Compare
spnda
approved these changes
Jan 25, 2024
cdavis5e
requested changes
Jan 25, 2024
I hate when that happens! 😖 To help with this risk, I try to either assign myself to the related issue (although I didn't do that here because it was a quick fix), or add it to the upcoming task list (which I did do on this one). But I'm open to other mechanisms for us to communicate what's being worked on. It would be good to have some mechanism that we can all collaborate on.
Okay. Looking forward to seeing it. |
cdavis5e
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVK_USE_METAL_PRIVATE_APIbuild setting to allow MoltenVK to be built with access to Metal private API calls.MVK_USE_METAL_PRIVATE_APIis enabled in a MoltenVK build.lineWidthRangeandlineWidthGranularityto reasonable arbitrary values.Fixes #1657.
Fixes #1670.
Replaces #2091.
Future PR's can leverage
MVK_USE_METAL_PRIVATE_APIto add additional private functionality, as it is uncovered.