Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node v20 #1730

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Update to node v20 #1730

wants to merge 6 commits into from

Conversation

SikhNerd
Copy link
Contributor

@SikhNerd SikhNerd commented Aug 11, 2024

  • Disable tests for now as jest is fully abandoned
  • Placeholder tslint to eslint conversion
  • Bare minimum updates to other libs to be compatible, larger updates suggested

- Disable tests for now as jest is fully abandoned
- Placeholder eslint to tslint conversion
- Bare minimum updates to other libs to be compatible, larger updates
  suggested
@saintsoldierx saintsoldierx temporarily deployed to sttm-web-pul-update-nod-qrbolm August 11, 2024 21:03 Inactive
@SikhNerd
Copy link
Contributor Author

Still has a few high-level errors:

e.g.


Check the render method of `HomePageIcons`. See https://fb.me/react-warning-keys for more information.
    in div (created by HomePageIcons)
    in HomePageIcons (created by SearchForm)
    in div (created by SearchForm)
    in div (created by SearchForm)
    in SearchForm (created by Home)
    in Home (created by ConnectFunction)
    in ConnectFunction (created by Context.Consumer)
    in div (created by Layout)
    in Layout (created by ConnectFunction)
    in ConnectFunction (created by Context.Consumer)
    in Route (created by Root)
    in Switch (created by Root)
    in GlobalHotKeys (created by Root)
    in Router (created by BrowserRouter)
    in BrowserRouter (created by Root)
    in Root
    in Provider
    in QueryClientProvider react.development.js:315:29

and

Uncaught (in promise) TypeError: r is undefined
    _createForOfIteratorHelper app.js:15721
    getShabadList get-shabad-list.ts:19
    promise callback*getShabadList/< get-shabad-list.ts:15
    getShabadList get-shabad-list.ts:13
    suggestionTimeout Autocomplete.js:119
    setTimeout handler*componentDidUpdate Autocomplete.js:117
    React 6
    unstable_runWithPriority scheduler.development.js:653
    React 5
    unstable_runWithPriority scheduler.development.js:653
    React 6
    SearchForm SearchForm.js:307
    promise callback*SearchForm/</< SearchForm.js:306
    SearchForm SearchForm.js:340
    React 7
app.js:15721:68

But it compiles and we can work towards functional fixes

@SikhNerd
Copy link
Contributor Author

Also, all the test hooks are broken, so need --no-verify until fixed

@saintsoldierx saintsoldierx had a problem deploying to sttm-web-pul-update-nod-j8gvri August 12, 2024 22:12 Failure
@saintsoldierx saintsoldierx had a problem deploying to sttm-web-pul-update-nod-j8gvri August 12, 2024 22:23 Failure
@saintsoldierx saintsoldierx had a problem deploying to sttm-web-pul-update-nod-j8gvri August 12, 2024 22:40 Failure
@saintsoldierx saintsoldierx had a problem deploying to sttm-web-pul-update-nod-j8gvri August 12, 2024 22:56 Failure
@gurjit03
Copy link
Collaborator

Also, all the test hooks are broken, so need --no-verify until fixed

This is fixed now. But we just have to do all the npm i --legacy-peer-deps in order to avoid issues with peer dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants