-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to node v20 #1730
Open
SikhNerd
wants to merge
6
commits into
dev
Choose a base branch
from
update_node_version
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update to node v20 #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SikhNerd
commented
Aug 11, 2024
•
edited
Loading
edited
- Disable tests for now as jest is fully abandoned
- Placeholder tslint to eslint conversion
- Bare minimum updates to other libs to be compatible, larger updates suggested
- Disable tests for now as jest is fully abandoned - Placeholder eslint to tslint conversion - Bare minimum updates to other libs to be compatible, larger updates suggested
Still has a few high-level errors: e.g.
and
But it compiles and we can work towards functional fixes |
Also, all the test hooks are broken, so need --no-verify until fixed |
saintsoldierx
had a problem deploying
to
sttm-web-pul-update-nod-j8gvri
August 12, 2024 22:12
Failure
saintsoldierx
had a problem deploying
to
sttm-web-pul-update-nod-j8gvri
August 12, 2024 22:23
Failure
saintsoldierx
had a problem deploying
to
sttm-web-pul-update-nod-j8gvri
August 12, 2024 22:40
Failure
saintsoldierx
had a problem deploying
to
sttm-web-pul-update-nod-j8gvri
August 12, 2024 22:56
Failure
This is fixed now. But we just have to do all the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.