Initial code review #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- organize usings (using the VS code feature), remove unused ones - file name typo - a few refactoring suggestions (less repetitive, hopefully more readable, save some real estate) - automatic formatting based on the editorconfig (e.g., empty lines add/remove) - RetrieveMenu method - capital R (.NET conventions)
|
If you want to organize usings or clean up code in bulk, you can We use this on the integration repos to make sure formatting rules are followed as part of a PR's CI run. Here's an example in Xperience by Kentico Lucene |
…tools but not sample code like this
kentico-matthews
added a commit
that referenced
this pull request
Aug 7, 2024
kentico-matthews
added a commit
that referenced
this pull request
Aug 9, 2024
kentico-matthews
added a commit
that referenced
this pull request
Aug 9, 2024
kentico-matthews
added a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review after the inital repo push
See my small refactoring and other suggestions in this PR: