make doSaveDependingOnFiles nullable again #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfx413
force-pushed
the
master
branch
4 times, most recently
from
255ea03 to
28360cd
Compare
request-checks: true
Spamercz
requested changes
Dec 5, 2019
src/DI/ClassAliasMap.php
Outdated
| @@ -3,6 +3,6 @@ | |||
| declare(strict_types = 1); | |||
|
|
|||
| return [ | |||
| \Kdyby\DoctrineCache\NotImplementedException::class => \Kdyby\DoctrineCache\Exception\NotImplementedException::class, | |||
| \Kdyby\DoctrineCache\Exception::class => \Kdyby\DoctrineCache\Exception\Exception::class, | |||
| \Kdyby\DoctrineCache\Exception\NotImplementedException::class => \Kdyby\DoctrineCache\Exception\NotImplementedException::class, | |||
There was a problem hiding this comment.
This should not be here. You are aliasing same class name. This is here just to provide backwards compatibility for renamed namespaced class \Kdyby\DoctrineCache\NotImplementedException
src/DI/ClassAliasMap.php
Outdated
| \Kdyby\DoctrineCache\NotImplementedException::class => \Kdyby\DoctrineCache\Exception\NotImplementedException::class, | ||
| \Kdyby\DoctrineCache\Exception::class => \Kdyby\DoctrineCache\Exception\Exception::class, | ||
| \Kdyby\DoctrineCache\Exception\NotImplementedException::class => \Kdyby\DoctrineCache\Exception\NotImplementedException::class, | ||
| \Throwable::class => \Throwable::class, |
|
Hello, sorry for inconvenience. Should be OK now. |
Spamercz
approved these changes
Dec 9, 2019
|
No worries :). Merging |
|
Can this be tagged, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #23