Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38128 - allow blank image mode digests #11275

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ianballou
Copy link
Member

What are the changes introduced in this pull request?

Allows blank digests to support the format of bootc internals publish-rhsm-facts:

{
  "bootc.booted.image": "quay.io/centos-bootc/centos-bootc:stream10",
  "bootc.booted.version": "stream10.20241230.0",
  "bootc.booted.digest": "sha256:48884b0220bb075ce50ae31d8e6739f3e9b3870e746a4b3c87ea2fe3353b7208",
  "bootc.staged.image": "",
  "bootc.staged.version": "",
  "bootc.staged.digest": "",
  "bootc.rollback.image": "quay.io/centos-bootc/centos-bootc:stream10",
  "bootc.rollback.version": "stream10.20241216.0",
  "bootc.rollback.digest": "sha256:e168d2f013ed4cc89771d2c5d1b15951ae09792ed3d647226f48e5b62316d7fb",
  "bootc.available.image": "",
  "bootc.available.version": "",
  "bootc.available.digest": ""
}

Considerations taken when implementing this change?

Our UI appears to be checking for empty string properly as opposed to null.

What are the testing steps for this pull request?

Register a bootc host with a /etc/rhsm/facts/bootc.facts file that looks like what's above.

Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 👍🏼

@sjha4
Copy link
Member

sjha4 commented Jan 15, 2025

Probably needs a force push to stop running using Node 14 matrix or we can ignore that failure..

@ianballou ianballou merged commit dfa1ec8 into Katello:master Jan 17, 2025
19 checks passed
@ianballou ianballou deleted the 38128-blank-digest branch January 17, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants