Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Canvas): add useVizNodeModel #1869

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Dec 17, 2024

Context

This commit offers a convenient mechanism to subscribe to updates from a given vizNode model, and at the same time, provides a mechanism to update the model as well.

Notes

There is an unrelated situation with Kamelets where the custom mapper might return undefined for a property key if it is empty.

@lordrip lordrip force-pushed the feat/add-use-viznode-model branch from c6d6eac to a928459 Compare December 17, 2024 18:55
@lordrip lordrip force-pushed the feat/add-use-viznode-model branch from a928459 to b998cf4 Compare December 17, 2024 23:28
@lordrip lordrip changed the title feat(Canvas): add useVizNodeModel feat(Canvas): add useVizNodeModel Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 93.65079% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (cc6e1af) to head (b1babb3).

Files with missing lines Patch % Lines
...nents/Visualization/Canvas/Form/CanvasFormBody.tsx 93.54% 2 Missing ⚠️
...s/Visualization/Custom/hooks/disable-step.hook.tsx 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1869      +/-   ##
============================================
- Coverage     78.48%   78.48%   -0.01%     
  Complexity      367      367              
============================================
  Files           468      469       +1     
  Lines         14777    14766      -11     
  Branches       2832     2736      -96     
============================================
- Hits          11598    11589       -9     
- Misses         2906     3089     +183     
+ Partials        273       88     -185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip added this to the 2.4.0 milestone Dec 18, 2024
@lordrip lordrip self-assigned this Dec 18, 2024
@lordrip lordrip force-pushed the feat/add-use-viznode-model branch 4 times, most recently from fdf6ca3 to 6de625f Compare December 19, 2024 12:20
@lordrip lordrip force-pushed the feat/add-use-viznode-model branch from 43d72ef to 366618a Compare January 7, 2025 08:53
This commit offers a convenient mechanism to subscribe to updates from a
given vizNode model, and at the same time, offers a mechanism to update
the model as well.
@lordrip lordrip force-pushed the feat/add-use-viznode-model branch from 366618a to b1babb3 Compare January 8, 2025 09:02
@lordrip lordrip modified the milestones: 2.4.0, 2.5.0 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant