-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Canvas): add useVizNodeModel
#1869
Draft
lordrip
wants to merge
2
commits into
KaotoIO:main
Choose a base branch
from
lordrip:feat/add-use-viznode-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
feat/add-use-viznode-model
branch
from
December 17, 2024 18:55
c6d6eac
to
a928459
Compare
lordrip
force-pushed
the
feat/add-use-viznode-model
branch
from
December 17, 2024 23:28
a928459
to
b998cf4
Compare
lordrip
changed the title
feat(Canvas): add useVizNodeModel
feat(Canvas): add Dec 17, 2024
useVizNodeModel
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1869 +/- ##
============================================
- Coverage 78.48% 78.48% -0.01%
Complexity 367 367
============================================
Files 468 469 +1
Lines 14777 14766 -11
Branches 2832 2736 -96
============================================
- Hits 11598 11589 -9
- Misses 2906 3089 +183
+ Partials 273 88 -185 ☔ View full report in Codecov by Sentry. |
lordrip
force-pushed
the
feat/add-use-viznode-model
branch
4 times, most recently
from
December 19, 2024 12:20
fdf6ca3
to
6de625f
Compare
lordrip
force-pushed
the
feat/add-use-viznode-model
branch
from
January 7, 2025 08:53
43d72ef
to
366618a
Compare
This commit offers a convenient mechanism to subscribe to updates from a given vizNode model, and at the same time, offers a mechanism to update the model as well.
lordrip
force-pushed
the
feat/add-use-viznode-model
branch
from
January 8, 2025 09:02
366618a
to
b1babb3
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This commit offers a convenient mechanism to subscribe to updates from a given vizNode model, and at the same time, provides a mechanism to update the model as well.
Notes
There is an unrelated situation with
Kamelets
where the custom mapper might returnundefined
for a property key if it is empty.