Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Rest): Add Rest visual entity #1860

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Dec 16, 2024

Context

This commit adds support for the Rest DSL from Apache Camel.

Notes

As @apupier spotted, there are two groups of issues that needs to be handled separately:

uniforms-patternfly-related issues:

  • on first save, some invalid block code is added
  • cannot remove a security definitions if you provide a boolean or dropdown value first, then you try to remove the content, it will keep some of them (boolean/dropdown) or use empty curly brace:

CanvasFormBody filtering issues: (#1890)

  • the required fields are not appearing in the Required tab
  • In modified tab, all nested fields are appearing

Screencast

Screencast.From.2025-01-07.15-49-40.mp4

fix: #1505

partially implements:
#54

@lordrip lordrip force-pushed the feat/add-rest-entity branch 3 times, most recently from 6b0680b to 531a3e1 Compare December 17, 2024 08:26
@lordrip lordrip force-pushed the feat/add-rest-entity branch from 531a3e1 to 3c17d36 Compare January 7, 2025 13:09
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 82.52427% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (5f57196) to head (2e7a35c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ls/visualization/flows/camel-rest-visual-entity.ts 84.21% 9 Missing ⚠️
...n/flows/support/camel-component-default.service.ts 0.00% 7 Missing ⚠️
...i/src/models/visualization/flows/templates/rest.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1860      +/-   ##
============================================
+ Coverage     78.44%   78.48%   +0.03%     
- Complexity      365      367       +2     
============================================
  Files           466      468       +2     
  Lines         14682    14777      +95     
  Branches       2730     2832     +102     
============================================
+ Hits          11518    11598      +80     
+ Misses         3075     2906     -169     
- Partials         89      273     +184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip force-pushed the feat/add-rest-entity branch 3 times, most recently from d84cd72 to 9b1359d Compare January 7, 2025 14:01
@lordrip lordrip marked this pull request as ready for review January 7, 2025 14:57
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you mentioned some all?) of them during a call but to have it listed on the PR on what are the current limitations and what needs to be done next:

  • on first save, some invalid block code is added
    image
  • the required fields are not appearing in the Required tab
  • In modified tab, all nested fields are appearing
  • cannot remove a security definitions if you provide a boolean or dropdown value first, then you try to remove the content, it will keep some of them (boolean/dropdown) or use empty curly brace:
    image

@apupier
Copy link
Member

apupier commented Jan 7, 2025

There is the possibility to set the attribute disable but there is not the right-click menu like on other step that can be disabled

@lordrip
Copy link
Member Author

lordrip commented Jan 7, 2025

yes @apupier, you're right, I mentioned some of those limitations coming from the form library 😢 , so there's not much we can do now. For the disabling functionality, that's something I can fix, I'll update the PR

This commit adds support for the Rest DSL from Apache Camel.

fix: KaotoIO#1505
fix: KaotoIO#54
@lordrip lordrip force-pushed the feat/add-rest-entity branch from 9b1359d to 2e7a35c Compare January 7, 2025 17:13
Copy link

sonarqubecloud bot commented Jan 7, 2025

@lordrip lordrip merged commit cc6e1af into KaotoIO:main Jan 8, 2025
13 checks passed
@lordrip lordrip deleted the feat/add-rest-entity branch January 8, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a visual representation for the Rest entity
3 participants