feat: input enter with ime (#414)

Kanaries · Sep 30, 2024 · 9d0c30a · 9d0c30a
1 parent d15ac9a
commit 9d0c30a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/graphic-walker/src/components/askViz/index.tsx b/packages/graphic-walker/src/components/askViz/index.tsx
@@ -112,7 +112,7 @@ const AskViz: React.FC<{
                 value={query}
                 onChange={(e) => setQuery(e.target.value)}
                 onKeyDown={(e) => {
-                    if (e.key === 'Enter' && loading === false && query.length > 0) {
+                    if (e.key === 'Enter' && !e.nativeEvent.isComposing && loading === false && query.length > 0) {
                         startQuery();
                     }
                 }}

diff --git a/packages/graphic-walker/src/components/chat/index.tsx b/packages/graphic-walker/src/components/chat/index.tsx
@@ -219,7 +219,7 @@ export const VegaliteChat = observer(function VegaliteChat(props: {
                     rows={1}
                     value={query}
                     onKeyDown={(e) => {
-                        if (e.key === 'Enter' && !e.shiftKey && loading === false && query.length > 0) {
+                        if (e.key === 'Enter' && !e.nativeEvent.isComposing && !e.shiftKey && loading === false && query.length > 0) {
                             e.preventDefault();
                             submit();
                         }

diff --git a/packages/graphic-walker/src/components/painter/components.tsx b/packages/graphic-walker/src/components/painter/components.tsx
@@ -172,7 +172,7 @@ export const ClickInput = (props: { value: string; onChange: (v: string) => void
             defaultValue={props.value}
             onBlur={doChange}
             onKeyUp={(e) => {
-                if (e.key === 'Enter') {
+                if (e.key === 'Enter' && !e.nativeEvent.isComposing) {
                     doChange(e as unknown as { target: HTMLInputElement });
                     return false;
                 } else {

diff --git a/packages/graphic-walker/src/fields/filterField/slider.tsx b/packages/graphic-walker/src/fields/filterField/slider.tsx
@@ -66,7 +66,7 @@ const ValueInput: React.FC<ValueInputProps> = (props) => {
             onChange={(e) => setInnerValue(e.target.value)}
             onBlur={handleSubmitValue}
             onKeyDown={(e) => {
-                if (e.key === 'Enter') {
+                if (e.key === 'Enter' && !e.nativeEvent.isComposing) {
                     handleSubmitValue();
                 }
             }}