Prepare new release #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You may now read a shape file on your own, and pass the corresponding spatial object (or e.g. a subset of it) to the funcion read_monthly_data_over_shape(). You may also set both, "file" and "shape" to NULL and should receive data for the whole area of Germany.
r@data@values is logical(0) for the whole of Germany, however getValues() returns the values
Add shape arg
use coordinate matrix directly within []
version 1 is deprecated
Add overview vignette
to remove Warning "LazyData DB of 5.2 MB without LazyDataCompression set"
Remove - filter_by_extension_asc_gz() - filter_by_extension_tgz() Ignore case when checking file name extension
in download_if_not_there()
using roxygen2md::roxygen2md()
The script identifies what exported functions are related to each other and modifies the source files by adding a seealso section to the Roxygen header.
Use download_and_extract_radolan()
- improve names, use intermediate variables "first_url", "last_url" for better readability - use grep(p, x, value = TRUE) instead of x[grep(p, x)]
- download_if_not_there() -> download() - check_or_download_shapes_germany() -> download_shapes_germany() - add arg. "download" to default_projection_file()
Use variable "is_no_extension" instead
and make the existing functions wrappers around it: - read_daily_data_over_shape() - read_monthly_data_over_shape()
and simplify the safe selection of the function
Use more general argument "resolution" instead of logical argument "is_daily". This allows to extend the function to more time resolutions.
Read data over shape
as last try didnt work out
which worked locally using remotes::install_version("rgdal", "1.6-7")
is not implemented in remotes::remotes::install_deps() (in [email protected]) despite the fact that it is documented here: https://remotes.r-lib.org/#dependencies-on-github
package manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is