Skip to content

Commit

Permalink
Update various comments
Browse files Browse the repository at this point in the history
  • Loading branch information
PaulVanSchayck committed Oct 12, 2023
1 parent 5cfba49 commit 38a3f8a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
10 changes: 2 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,15 +149,9 @@ This library is used to build an Environmental Data Retrieval (EDR) API, serving

## TODOs
Help is wanted in the following areas to fully implement the EDR spec:
* See TODOs in code listing various small inconsistencies in the spec
* In various places there could be more validation on content

## License

Apache License, Version 2.0

## Authors

Members of the KNMI Data Platform team. Reachable at [email protected].

## Copyright

Koninklijk Nederlands Meteorologisch Instituut (KNMI)
2 changes: 1 addition & 1 deletion src/edr_pydantic/collections.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class Collection(EdrBaseModel):
links: List[Link]
extent: Extent
data_queries: Optional[DataQueries] = None
# TODO According to req A.13 it shall be CRSDetails object, according to C.1 it is a string array
# TODO According to req A.13 it shall be CRS object, according to C.1 it is a string array
crs: Optional[List[str]] = None
output_formats: Optional[List[str]] = None
parameter_names: Dict[str, Parameter]
Expand Down
4 changes: 3 additions & 1 deletion src/edr_pydantic/reference_system.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
from .base_model import EdrBaseModel


# TODO According to req A.13 a collection has a CRS object, according to C.1 it is a string array
# For now, this is unused
class CRS(EdrBaseModel):
name: str # # This MAY be an EPSG code
name: str # This MAY be an EPSG code
# TODO: Implement WKT (Well Known Text) validator
wkt: str

0 comments on commit 38a3f8a

Please sign in to comment.