Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/UseTheme - Zustand Persist로 테마 데이터 변경 외 2개 수정사항 #75

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

whitedev7773
Copy link
Collaborator

@whitedev7773 whitedev7773 commented Nov 6, 2024

Description

Zustand Persist로 테마 데이터 변경 외 1개 수정사항

Changes

  • useTheme.js : Zustand Persist로 state 공유 및 localstorage에 데이터 저장 방식 변경
  • HistoryPreview.jsx : ? Null 체크 추가
  • theme*.css 파일을 /public으로 이동
  • 404 페이지 높이 조정

Test Checklist

  • 프로덕션 환경에서 테마 적용되는지 체크
  • 홈 -> 다른 페이지 -> 홈처럼 홈으로 되돌아올 때 HistoryPreview에서 Null 에러가 발생하는지 체크

@whitedev7773 whitedev7773 added the enhancement New feature or request label Nov 6, 2024
@whitedev7773 whitedev7773 self-assigned this Nov 6, 2024
@whitedev7773 whitedev7773 changed the title Fix/UseTheme - Zustand Persist로 테마 데이터 변경 외 1개 수정사항 Fix/UseTheme - Zustand Persist로 테마 데이터 변경 외 2개 수정사항 Nov 6, 2024
@Village-GG-Water Village-GG-Water merged commit 8698e95 into dev Nov 6, 2024
1 check passed
@Village-GG-Water Village-GG-Water deleted the fix/useTheme branch November 6, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants