Fix cost attribution of inline frames in disassembly view #672
Conversation
Previously, we put the cost of an inline frame into a container indexed by the inline symbol. But during disassembly, we never get to query that data again, since we cannot disassemble an inline frame. Instead, we need to be able to query the cost for arbitrary binary offsets, independent of their originating symbol. The patch here achieves this by lifting the OffsetLocationCostMap out of the CallerCalleeEntryMap into CallerCalleeResults, but mapped by the binary name. This way we can efficiently store and lookup the data of a given offset within a specific binary during disassembly, which allows us to show the cost for inlined code in the disassembly view. Fixes: #671
milianw
force-pushed
the
work/inline-assembly-cost
branch
from
8e20e25
to
c3e1682
Compare
|
@arvidfm @lievenhey @GitMensch care to try out the appimage in here for inline cost attribution in the disassembly addr view? I think that should be fixed now |
|
@arvidfm you find the right artifact here: https://github.com/KDAB/hotspot/actions/runs/10662946666/artifacts/1881066271 (go to "build appimage, then to its summary, then click on "skipped by" until you get to actual binaries) |
|
Giving it a try on one of my projects, the inlined instructions seem to be getting annotated properly now, but the corresponding source lines on the left are still missing the costs, is that expected? |
|
ok cool, I'll merge this as-is for now and then look at the source file/line problem next when I find the time. the solution to that is probably going to look similar, but we need to make sure that we don't show confusing numbers when the same function is inlined into multiple ones |
Previously, we put the cost of an inline frame into a container indexed by the inline symbol. But during disassembly, we never get to query that data again, since we cannot disassemble an inline frame. Instead, we need to be able to query the cost for arbitrary binary offsets, independent of their originating symbol.
The patch here achieves this by lifting the OffsetLocationCostMap out of the CallerCalleeEntryMap into CallerCalleeResults, but mapped by the binary name. This way we can efficiently store and lookup the data of a given offset within a specific binary during disassembly, which allows us to show the cost for inlined code in the disassembly view.
Fixes: #671