Fix JaCoCo test report coverage #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage was being reported as 0% because JaCoCo could not find `.class` files — when AtomicFU Gradle plugin is applied, the `.class` files are output to `classes/atomicfu-orig` directory instead of `classes/kotlin`.
twyatt
added
the
maintenance
cedrickcooke
approved these changes
Mar 5, 2024
Phoenix7351
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage was being reported as 0% because JaCoCo could not find
.classfiles — when AtomicFU Gradle plugin is applied, the.classfiles are output toclasses/atomicfu-origdirectory instead ofclasses/kotlin.Without AtomicFU Gradle plugin
Tested by making the following
khronicle-core/build.gradle.ktschanges:plugins { // .. - id("kotlinx-atomicfu") } kotlin { // .. sourceSets { // .. commonMain.dependencies { + implementation("org.jetbrains.kotlinx:atomicfu:0.23.1") } } }Class files are where I traditionally have known them to be:
With AtomicFU Gradle plugin
With the AtomicFU Gradle plugin applied, class files are relocated:
Using
classes/atomicfuresults in the following JaCoCo errors (and under reported coverage):While using
classes/atmoicfu-origproperly reports coverage.