Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update agp to v8.1.0 #226

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Update agp to v8.1.0 #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6e0dd0
Update agp to v8.1.0
juul-mobile-bot Jul 28, 2023
7ab8571
Drop JVM toolchain workaround
twyatt Jul 28, 2023
6f4a6ac
Replace usages of deprecated AGP DSL
twyatt Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[versions]
agp = "8.0.2"
android-compile = "android-30"
agp = "8.1.0"
android-compile = "30"
android-min = "21"
jvm-toolchain = "11"
kotlin = "1.9.0"
Expand Down
15 changes: 2 additions & 13 deletions runtime/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,8 @@ kotlin {
}

android {
// Workaround (for `jvmToolchain` not being honored) needed until AGP 8.1.0-alpha09.
// https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support
compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
}

compileSdkVersion(libs.versions.android.compile.get())

defaultConfig {
minSdkVersion(libs.versions.android.min.get())
}

compileSdk = libs.versions.android.compile.get().toInt()
defaultConfig.minSdk = libs.versions.android.min.get().toInt()
namespace = "com.juul.exercise.runtime"
}

Expand Down