Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS SDK to v3 #48

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Update AWS SDK to v3 #48

wants to merge 12 commits into from

Conversation

zemberdotnet
Copy link
Member

No description provided.

@zemberdotnet zemberdotnet requested review from a team September 26, 2023 17:59
@zemberdotnet zemberdotnet requested review from a team as code owners September 26, 2023 17:59
@zemberdotnet zemberdotnet requested a review from a team September 26, 2023 17:59
@socket-security
Copy link

socket-security bot commented Sep 26, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/jest 29.5.5 None +5 3.93 MB types
aws-sdk-client-mock 3.0.0 environment +16 7.66 MB m-radzikowski
@aws-sdk/client-dynamodb 3.427.0 network, filesystem, shell, environment +78 6.28 MB aws-sdk-bot
@aws-sdk/lib-dynamodb 3.427.0 network, filesystem, shell, environment +80 6.53 MB aws-sdk-bot
@jupiterone/typescript-tools 13.2.2...18.1.1 environment +282/-486 106 MB jupiterone-dev
@jupiterone/eslint-config 1.0.2...2.1.0 None +19/-52 5.17 MB jupiterone-dev
@types/node 13.13.52...18.17.18 None +0/-0 3.73 MB types
@lifeomic/attempt 3.0.0...3.0.3 None +0/-0 32.6 kB lifeomicdev

🚮 Removed packages: @types/[email protected], [email protected]

@xdumaine
Copy link
Contributor

xdumaine commented Oct 4, 2023

uuid -> randomUUID

JW - why?

@zemberdotnet
Copy link
Member Author

@xdumaine I think at the time I wanted to set the engines requirements to >= Node 18, so just used the native functionality rather than an external dependency.

@zemberdotnet zemberdotnet requested a review from a team as a code owner October 11, 2023 14:51
@Druotic Druotic removed the request for review from a team December 12, 2023 23:26
zemberdotnet
zemberdotnet commented Feb 2, 2024
View reviewed changes
README.md
service: dynamodb
const documentClient = DynamoDBDocumentClient.from(ddb, {
marshallOptions: {
removeUndefinedValues: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this recreates the behavior of v2. Of all the things in this PR this is the one I'm most concerned about as far as breaking behavior. However, it seems removeUndefinedValues: true recreates what was the default behavior in v2:
aws/aws-sdk-js-v3#1816

@xdumaine xdumaine mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdumaine xdumaine xdumaine approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zemberdotnet @xdumaine