-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FirewallRule class #86
Closed
+64
−0
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"$id": "#FirewallRule", | ||
"description": "A network rule defined on a Firewall or host.", | ||
"type": "object", | ||
"allOf": [ | ||
{ "$ref": "#Entity" }, | ||
{ | ||
"properties": { | ||
"priority": { | ||
"description": "Priority of the firewall rule. Typically, a number between 0 and 65535.", | ||
"type": "integer" | ||
}, | ||
"source": { | ||
"description": "Source of the firewall rule. Can be IP address, CIDR range, '*', or other firewall-defined options.", | ||
"type": "string" | ||
}, | ||
"sourceIp": { | ||
"description": "Source IP of the firewall rule.", | ||
"type": "string", | ||
"format": "ip" | ||
}, | ||
"sourcePort": { | ||
"description": "Source port of the firewall rule. Typically an integer between 0 and 65535, but could also be '*' or range of ports.", | ||
"type": ["integer", "string"] | ||
}, | ||
"destination": { | ||
"description": "Destination of the firewall rule. Can be IP address, CIDR range, '*', or other firewall-defined options.", | ||
"type": "string" | ||
}, | ||
"destinationIp": { | ||
"description": "Destination IP of the firewall rule.", | ||
"type": "string", | ||
"format": "ip" | ||
}, | ||
"destinationPort": { | ||
"description": "Destination port of the firewall rule. Typically an integer between 0 and 65535, but could also be 'Any', '*', or range of ports.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we recommend only |
||
"type": ["integer", "string"] | ||
}, | ||
"protocol": { | ||
"description": "The protocol of the firewall rule.", | ||
"type": "string", | ||
"examples": ["TCP", "UDP", "*"] | ||
}, | ||
"direction": { | ||
"description": "The direction defined by the firewall rule, typically 'ingress' or 'egress'", | ||
"type": "string", | ||
"examples": ["ingress", "egress"] | ||
}, | ||
"action": { | ||
"description": "The action defined by the firewall rule, typically 'Allow' or 'Deny'", | ||
"type": "string", | ||
"examples": ["allow", "deny"] | ||
} | ||
}, | ||
"required": [] | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we need to port these changes to the AWS integration? It looks like we just put these rules in an array on a key for that integration.
https://bitbucket.org/jupiterone/jupiter-integration-aws/src/b1b082a76600f85738911adbea9d4112869059e7/src/integration-aws/ec2/converters/entities.ts?at=master#entities.ts-583
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also assume you already took a look at Rule, but thought I'd bring that up as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if this goes through I think it'd be good to get it into existing integrations like AWS, since the
JSON.stringify(ipPermission)
operation makes these properties useless from a query language perspective.I have looked at
Rule
but IMO a firewall rule is a super-specific class of configuration (as indicated by the common properties shared across all firewall rules)