Int 10917 #202
Open
Int 10917 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehisonprada
commented
May 3, 2024
jehisonprada
commented
- Add IpRange and Port Schemas
- Added unit tests for validateSchema for newly added Schemas
jehisonprada
commented
May 3, 2024
VDubber
reviewed
May 3, 2024
VDubber
reviewed
May 3, 2024
VDubber
reviewed
May 3, 2024
There was a problem hiding this comment.
Note: We need somehow to declare that there is a required relationship from Port to IP address. @chrichts, we need a way to declare that or we will end up with IP address data being added to port entities.
VDubber
reviewed
May 3, 2024
VDubber
reviewed
May 3, 2024
VDubber
reviewed
May 3, 2024
Co-authored-by: Samuel Poulton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.