Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keymap): not shadow keymap desc so make blink.cmp happy #367

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

tim3nd
Copy link
Contributor

@tim3nd tim3nd commented Dec 6, 2024

fix Saghen/blink.cmp#441

Currently blink.cmp use desc to identify blink.cmp keymap, so shadow decs option in lean.nvim would make stack overflow in blink.cmp side.

I think this should mainly be handled for blink.cmp, but restore desc option after cleanup by lean.nvim seems also a reasonable default.

@Julian
Copy link
Owner

Julian commented Dec 6, 2024

Thanks, I've seen this error myself in playing with blink.cmp and had no idea why I couldn't see where it was being caused.

@Julian Julian merged commit fff4f10 into Julian:main Dec 6, 2024
6 checks passed
@tim3nd
Copy link
Contributor Author

tim3nd commented Dec 6, 2024

Just FYI, blink.cmp use desc here to deduplicate of the fallback keymap configuration. :)
I also tried to improve this in blink.cmp but haven't found a clear and suitable method yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow in nvim_replace_termcodes
2 participants