Merge pull request #101 from cstjean/fix-assets

Fix /assets/ loading code
JuliaWeb · Jan 7, 2020 · cd04965 · cd04965
2 parents 5e2a060 + a55501d
commit cd04965
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -195,7 +195,11 @@ For example:
 
 ## Serving static files from a package
 
-The `Mux.pkgfiles` middleware (included in `Mux.defaults`) serves static files under the `assets` directory in any Julia package at `/pkg/<PACKAGE>/`.
+Please use [AssetRegistry.jl](https://github.com/JuliaGizmos/AssetRegistry.jl) to
+register an assets directory.
+
+**DEPRECATED**: The `Mux.pkgfiles` middleware (included in `Mux.defaults`) serves static
+files under the `assets` directory in any Julia package at `/pkg/<PACKAGE>/`.
 
 ## Integrate with WebSocket
 

diff --git a/src/examples/files.jl b/src/examples/files.jl
@@ -60,14 +60,14 @@ function packagefiles(dirs=true)
                 return dir
             end
         end
-        Pkg.dir(pkg, ASSETS_DIR)
+        Pkg.dir(String(pkg), ASSETS_DIR)  # Pkg.dir doesn't take SubString
     end
 
     branch(req -> validpath(absdir(req), joinpath(req[:path]...), dirs=dirs),
-           req -> (Base.warn_once("""
+           req -> (Base.@warn("""
                         Relying on /pkg/ is now deprecated. Please use the package
                         `AssetRegistry.jl` instead to register assets directory
-                        """);
+                        """, maxlog=1);
                    fresp(joinpath(absdir(req), req[:path]...))))
 end