override mp4 default

JuliaWeb · Nov 5, 2024 · 3919eb0 · 3919eb0
1 parent f787d3e
commit 3919eb0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/mimedb/mimedb.jlon b/mimedb/mimedb.jlon
diff --git a/mimedb/update.jl b/mimedb/update.jl
@@ -94,6 +94,11 @@ begin
             _ext2mime[ex] = mime
         end
     end
+
+    # Changing the default mime for the .mp4 extension to video/mp4
+    # this is the more common and expected type, and makes the assumption that the file contains video
+    # The RFC https://www.rfc-editor.org/rfc/rfc4337.txt does not specify a **default** mime type for mp4 files, it should depend on content. application/mp4 should be used for mp4 files without video/audio content, so it is not necessarily a better default than video/mp4.
+    _ext2mime["mp4"] = "video/mp4"
 
     @info "✏  writing to file $mdb..."
     open(mdb, "w") do f

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -57,9 +57,11 @@ const mdn = Dict(
     ".jsonld" => "application/ld+json",
     ".mjs" => "text/javascript",
     ".mp3" => "audio/mpeg",
-    ".mp4" => "application/mp4",
+    ".mp4" => "video/mp4",
+    ".mp4s" => "application/mp4",
     ".mpeg" => "video/mpeg",
-    ".ogx" => "application/ogg",  ".otf" => "font/otf",
+    ".ogx" => "application/ogg",
+    ".otf" => "font/otf",
     ".png" => "image/png",
     ".pdf" => "application/pdf",
     ".rtf" => "application/rtf",