Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always check lib.sftp_dir_eof() in readdir() #20

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Always check lib.sftp_dir_eof() in readdir() #20

merged 1 commit into from
Oct 12, 2024

Conversation

JamesWrigley
Copy link
Collaborator

lib.sftp_readdir() can return null if there was an error or if it's at the end of the directory.

`lib.sftp_readdir()` can return null if there was an error or if it's at the end
of the directory.
@JamesWrigley JamesWrigley self-assigned this Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.04%. Comparing base (cf8fc39) to head (8c7d5d7).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/sftp.jl 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   62.97%   63.04%   +0.06%     
==========================================
  Files          11       11              
  Lines        3001     3006       +5     
==========================================
+ Hits         1890     1895       +5     
  Misses       1111     1111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesWrigley JamesWrigley merged commit 4c3b5b9 into master Oct 12, 2024
6 checks passed
@JamesWrigley JamesWrigley deleted the sftp branch October 12, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant