Add initial SFTP client support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix callback formatting - Replace all uses of `@async` with `Threads.@spawn`
Previously we were closing all the client operations while the client handler task was still running, which could lead to extra messages being processed while channels etc were being shut down (which could lead to segfaults).
This is required for SFTP support.
For SFTP support we need to support addings things other than SshChannels to Session's.
In case it fails when disconnecting/closing.
Sometimes this is useful for debugging when you want to ensure that task switches aren't occurring.
In practice these can fail for good reason if the remote end has already disconnected the socket.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 53.87% 59.52% +5.64%
==========================================
Files 10 11 +1
Lines 2424 2777 +353
==========================================
+ Hits 1306 1653 +347
- Misses 1118 1124 +6 ☔ View full report in Codecov by Sentry. |
It seems to be causing something to spin. Should be replaced with a different design anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with a bunch of other fixes/changes.