-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade generator script to use the latest Clang.jl #102
base: master
Are you sure you want to change the base?
Conversation
I believe Julia 1.5's |
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 20.86% 0.00% -20.87%
==========================================
Files 2 1 -1
Lines 139 215 +76
==========================================
- Hits 29 0 -29
- Misses 110 215 +105
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 20.86% 1.14% -19.72%
==========================================
Files 2 14 +12
Lines 139 2619 +2480
==========================================
+ Hits 29 30 +1
- Misses 110 2589 +2479
Continue to review full report at Codecov.
|
This is now ready for review. |
You might be interested in this. We can do the same thing to SuiteSparse.jl as long as it can be separated out into a separate repo. |
@omus thanks for the review! I've applied the suggestions and this is ready for another round of review. |
Good to go? |
Co-authored-by: Kristoffer Carlsson <[email protected]>
This is great. I'll try to take a look later. Sorry I didn't see it until now. |
I haven't gotten a chance to look at this yet, but if Downloads works on top of this then I'd say it's all good. Do you happen to have tried that out, @Gnimuc? |
I'll try to revisit this if I can find some time. |
fix #101
Should also fix #1, fix #39, fix #87, fix #88:
@add_def
macro(in most of the case, you don't need to use this macro) andone can peek what those types are actually defined by adding them to the(now Clang.jl can handle this automatically) There is an option to let Clang.jl generate mutable structs that can be safely tagged mutable.definition_whitelist
entry in the config toml file.CURL_SSLVERSION_DEFAULT
is not defined(generated) because the old Clang.jl cannot handle anonymous enums. Now this is fixed.curl
is exported.CURL_PROGRESSFUNC_CONTINUE
is now defined, not sure why the old Clang.jl failed to define it though.