HTTP.request(): infer socket_type_tls from sslconfig, if provided
#1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JuliaWeb#1104. This PR only affects client requests, because those were the only ones broken. For now OpenSSL is not supported in HTTP.jl servers (and, honestly, maybe that's a good thing, OpenSSL is kinda crap). I didn't just revert the change to SOCKET_TYPE_TLS[] because that change has been released for months and users may now be relying on `sslconfig` accepting an `OpenSSL.SSLContext` value, just as I was relying on it accepting an `MbedTLS.SSLConfig` value.
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 82.34% 82.81% +0.46%
==========================================
Files 32 32
Lines 3042 3072 +30
==========================================
+ Hits 2505 2544 +39
+ Misses 537 528 -9
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Bump. I think this is still relevant. |
quinnj
approved these changes
Apr 6, 2024
|
You're welcome! Thanks for writing HTTP.jl :) |
This was referenced May 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104.
This PR only affects client requests, because those were the only ones broken. For now OpenSSL is not supported in HTTP.jl servers.
I didn't just revert the change to SOCKET_TYPE_TLS[] because that change has been released for months and users may now be relying on
sslconfigaccepting anOpenSSL.SSLContextvalue, just as I was relying on it accepting anMbedTLS.SSLConfigvalue.