Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fast_substitute folding array of symbolics #1398

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AayushSabharwal
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 6.44%. Comparing base (6202fa4) to head (1ea3df5).
Report is 40 commits behind head on master.

Files with missing lines Patch % Lines
src/variable.jl 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1398      +/-   ##
=========================================
+ Coverage    3.95%   6.44%   +2.48%     
=========================================
  Files          51      51              
  Lines        4824    4841      +17     
=========================================
+ Hits          191     312     +121     
+ Misses       4633    4529     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal
Copy link
Contributor Author

The NaNMath error is trivial. The others I can't seem to replicate outside of running tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants