-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fit
docs
#1746
Fix fit
docs
#1746
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1746 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 144 144
Lines 8647 8647
=======================================
Hits 7433 7433
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
Any objections to merging this? |
I mentioned this in Issue #1701. For sure docstring for Beta should be removed, but currently fit has no general docstring for a distribution fit. The question is should it be added. |
IMO we should add a docstring for generic |
maybe related #1748 I assume now that |
Co-authored-by: David Widmann <[email protected]>
Anything else to do before merging? |
Anything else or can I merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the docstring included in the docs?
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Anything else? |
@devmotion should I merge? |
Merge? |
Why was this merged? Docs seem to be broken (missing docstrings): https://juliastats.org/Distributions.jl/dev/fit/ |
fit
doesn't need a specific docstring just forBeta
.