-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: FastForwardDiff v1.0.0 #97348
New package: FastForwardDiff v1.0.0 #97348
Conversation
JuliaRegistrator
commented
Dec 18, 2023
- Registering package: FastForwardDiff
- Repository: https://github.com/gerlero/FastForwardDiff.jl
- Created by: @gerlero
- Version: v1.0.0
- Commit: 5f39551848862ea7f372c37a9a4997a1ad9f388f
- Reviewed by: @gerlero
- Reference: gerlero/FastForwardDiff.jl@5f39551#commitcomment-135258406
- Description: Fast automatic derivatives of scalar functions in Julia
UUID: dda8b3af-db81-48ce-b77a-9f93a3049212 Repo: https://github.com/gerlero/FastForwardDiff.jl.git Tree: fe33c1f0b8f4cc0dfaffb08d41a32303c8462bff Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Your Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Hi @gerlero and congrats on the package! |
@gdalle Yes, it's very small (at least for now—I may add more features later), but I wanted a standalone package given that I'm using undocumented ForwardDiff functionality (which means it needs its own testing), plus I'm using it already in various projects—including the registered Fronts package for which it'd be a direct dependency. As for contributing the code here to ForwardDiff, and these were just my own thoughts, but I'm not sure they'll be able to take the changes given the fact that ForwardDiff already offers a different API for single-pass value and derivative via DiffResults, plus this package's current dependency on Unitful (which could be made a weakdep, but I'm not able to work on that for now) which might very likely be a dealbreaker for ForwardDiff. FWIW there are open issues at ForwardDiff for these features @ JuliaDiff/ForwardDiff.jl#328 & JuliaDiff/ForwardDiff.jl#610 where some of this stuff has been discussed. Is the package still acceptable for registration under these circumstances? [noblock] |
[noblock] Hi there, Concerning the second part – you could maybe ask for help concerning the weak dependency and maybe first ask whether it is a dealbreaker for them? |
@gdalle @kellertuer All right, I'll take the suggestion. As much as I'd prefer a simple wrapper package for this (it's how I've been doing it for a while), I understand your points and will try to open a PR at ForwardDiff for the |
Thank you! |
EDIT: I ended up finding a way to add Unitful support as a plain extension. |
Thanks again for the feedback and suggestions. I've taken the time and effort and have opened the relevant PRs at |
Very cool, thank you! |
Bump to avoid this being closed ( |
Bump |
Thanks again for the feedback. I'd like to close this one for now in favor of the changes merged into |
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock] |