Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TableTraits functions failing on non-standard index #103

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ReubenJ
Copy link

@ReubenJ ReubenJ commented Dec 22, 2024

When using an index other than the default RangeIndex, the TableTraits functions currently fail as they assume a monotonically increasing range beginning from 0.

This PR addresses that issue.

I also cleaned up the code as it was adding an extra special case for Strings that was not necessary.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9d20bc6). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage        ?   63.46%           
=======================================
  Files           ?        5           
  Lines           ?      260           
  Branches        ?        0           
=======================================
  Hits            ?      165           
  Misses          ?       95           
  Partials        ?        0           
Flag Coverage Δ
unittests 63.46% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants