Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download deprecation for Julia 1.6 #203

Closed
wants to merge 2 commits into from
Closed

Fix download deprecation for Julia 1.6 #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3fa098
Fix downlaod deprecation for Julia 1.6
mjram0s May 12, 2021
e9b259f
Set version to 1.5.3
mjram0s May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Conda"
uuid = "8f4d0f93-b110-5947-807f-2305c1781a2d"
version = "1.5.2"
version = "1.5.3"

[deps]
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
Expand Down
11 changes: 10 additions & 1 deletion src/Conda.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@ The main functions in Conda are:
```
"""
module Conda
using JSON, VersionParsing

using JSON
using VersionParsing

if VERSION >= v"1.6.0-DEV.923"
# Use Downloads.jl once Conda.jl drops support for Julia versions < 1.3
download(args...) = Base.invokelatest(Base.Downloads().download, args...)
else
using Base: download
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem needed — download is exported in earlier Julia versions, no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary but I'd prefer to be explicit about using Base.download for versions < 1.6

end

const deps_file = joinpath(dirname(@__FILE__), "..", "deps", "deps.jl")

Expand Down