Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imageplot docs #289

Merged
merged 7 commits into from
Sep 20, 2022
Merged

add imageplot docs #289

merged 7 commits into from
Sep 20, 2022

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Sep 2, 2022

Following #196.

Note that savefig(imageplot(...), "...png") doesn't work as expected.
I think this is marginal (docs only), but is a TODO.

==> EDIT: fixed, but too ugly to get in.

Needs JuliaImages/ImageInTerminal.jl#72 and JuliaImages/XTermColors.jl#9.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Base: 99.14% // Head: 99.14% // No change to project coverage 👍

Coverage data is based on head (fe09d30) compared to base (a03412b).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          31       31           
  Lines        1755     1755           
=======================================
  Hits         1740     1740           
  Misses         15       15           
Impacted Files Coverage Δ
src/show.jl 99.20% <0.00%> (ø)
src/graphics/imagegraphics.jl 65.62% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t-bltg t-bltg marked this pull request as draft September 2, 2022 08:46
@t-bltg t-bltg force-pushed the imp_docs branch 6 times, most recently from 9bf4149 to c01c2ca Compare September 4, 2022 13:38
@t-bltg t-bltg marked this pull request as ready for review September 20, 2022 17:02
@t-bltg t-bltg force-pushed the imp_docs branch 2 times, most recently from eebc093 to adfd664 Compare September 20, 2022 18:10
@t-bltg t-bltg merged commit c930de4 into JuliaPlots:master Sep 20, 2022
@t-bltg t-bltg deleted the imp_docs branch September 20, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants