Allow passing collection of tuples to series_annotations

[t-bltg]

Fix #3629. And some code cleanup.

Example

using Plots
plot([1, 2], [3, 4], series_annotations=[("A", :red), ("B", :blue)])
plot([1, 2], [3, 4], series_annotations=(["A", "B"], [:red, :blue]))  # also supported
plot([1, 2], [3, 4], series_annotations=[["A", "B"], [:red, :blue]])  # same as previous

Output

[codecov]

Codecov Report

Merging #3743 (c11fc9f) into master (2df85eb) will increase coverage by 0.06%.
The diff coverage is 71.42%.

❗ Current head c11fc9f differs from pull request most recent head 39cb596. Consider uploading reports for the commit 39cb596 to get more accurate results

@@            Coverage Diff             @@
##           master    #3743      +/-   ##
==========================================
+ Coverage   62.97%   63.03%   +0.06%     
==========================================
  Files          28       28              
  Lines        7063     7045      -18     
==========================================
- Hits         4448     4441       -7     
+ Misses       2615     2604      -11     

Impacted Files	Coverage Δ
src/backends.jl	60.52% <0.00%> (-0.54%)	⬇️
src/examples.jl	61.76% <ø> (ø)
src/components.jl	68.22% <71.56%> (+1.64%)	⬆️
src/args.jl	73.18% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df85eb...39cb596. Read the comment docs.

[mkborregaard]

Given that this is series-annotations, would it be make sense to allow passing of a tuple of equal-length vectors, e.g.

plot([1, 2], [3, 4], series_annotations=(["A", "B"], [:red, :blue]))

[t-bltg]

Given that this is series-annotations, would it be make sense to allow passing of a tuple of equal-length vectors, e.g.

plot([1, 2], [3, 4], series_annotations=(["A", "B"], [:red, :blue]))

I find this less readable than using plot(..., series_annotations=[("A", :red), ("B", :blue)]).

[t-bltg]

That PR was unreadable sorry, I've split it into two commits, the first one relative to the fix of the issue, and the second relative to code cleanup. @BeastyBlacksmith, I've removed the deprecated directed_curve as well.

[mkborregaard]

find this less readable than using

Yes sure. But most of the time you'll be plotting data from tables, and they will have that format, e.g. plot(height, shoes, seriesannotations = (names, textcolor). For series_annotations(as opposed to annotations) It's very rare to type them out in practice, because you'd tend to have more than 2-3 points. I guess accepting a zip is an easy workaround.

[t-bltg]

Yes sure. But most of the time you'll be plotting data from tables, and they will have that format, e.g. plot(height, shoes, seriesannotations = (names, textcolor). For series_annotations(as opposed to annotations) It's very rare to type them out in practice, because you'd tend to have more than 2-3 points. I guess accepting a zip is an easy workaround.

Ha, I think I misunderstood your first comment.
I've implemented what you expected (see the updated example), 🤞 for not breaking the CI.