-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fonts #3473
base: master
Are you sure you want to change the base?
WIP: Fonts #3473
Conversation
Perhaps I'm a little late to this discussion, but what are the clear advantages of separating font attrs into a new named tuple therefore breaking a lot of existing recipes (perhaps most of them)? This is a massive breaking change, but what are the clear advantages here? Additionally, this has to be implemented for all backends or else other backends would just stop working |
Not at all, it's an infant idea, but I wanted to see what it would look like. Advantages I see:
That said, it is a breaking change, and quite a bit of details to implement. It might be possible to implement it in a non-breaking fashion, where |
You may also look at #2854 where I wrote a macro to traverse into any Plot specific types (including Font) and creating the attributes automatically (incl. aliases). |
I started fiddling with a redefinition of the fonts system (as discussed in #3463)
It's currently in a state where it compiles and plots, but I've only done just enough adjustment in the
gr
backend to get it in "working" order. But I think it illustrates the idea.Maybe the gains aren't that big, and there's probably quite a bit of work left, but the shortening of the attribute list feels pretty good.