Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid having implicit imports. #23

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

jd-foster
Copy link
Contributor

@jd-foster jd-foster commented Nov 1, 2024

Changes using to import explicit formula ofusing Package: Package for dependent packages.
Possibly addresses #22

@BeastyBlacksmith
Copy link
Member

I'm more in favor of using using JSON: JSON and similar and only using import when something is getting extended.

However I'd be surprised, if it fixes #22

@jecs
Copy link

jecs commented Nov 1, 2024

May I ask why CI tests Julia 1.6? I believe that 1.10 is the new LTS version.

I wonder if the failing CI is related at all to #22.

@jd-foster
Copy link
Contributor Author

Even without issue 22, I think the Julia community is heading towards this style anyway.

@BeastyBlacksmith
Copy link
Member

To clarify: both using JSON: JSON and import JSON only bring JSON into namespace. The only difference is that import allows methods from JSON being extended without qualification while using JSON: JSON does not (AFAIK).

@jd-foster
Copy link
Contributor Author

@jd-foster
Copy link
Contributor Author

Changed to the using X: X form for Base64 and Kaleido_jll

@BeastyBlacksmith BeastyBlacksmith merged commit 4c8129d into JuliaPlots:main Nov 7, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants