Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bsdiff_classic] Update Bzip2 compat #9648

Merged
merged 5 commits into from
Oct 25, 2024
Merged

[bsdiff_classic] Update Bzip2 compat #9648

merged 5 commits into from
Oct 25, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Oct 19, 2024 •
edited
Loading

This will help testing JuliaIO/BSDiff.jl#49

giordano
giordano reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to trigger a rebuild of Bzip2 in a separate PR, so that we get it built for aarch64-freebsd (hopefully that works out-of-the-box without much hassle)

B/bsdiff_classic/build_tarballs.jl Outdated Show resolved Hide resolved
B/bsdiff_classic/build_tarballs.jl Show resolved Hide resolved
@nhz2 nhz2 marked this pull request as ready for review October 19, 2024 17:50
@giordano
Copy link
Member

License file is missing

@nhz2 nhz2 marked this pull request as draft October 19, 2024 18:26
@nhz2
Copy link
Contributor Author

nhz2 commented Oct 20, 2024

License file is missing

Nice catch.
I don't see a specific license file, so I'm adding the two ".c" files with a license at the top.

@nhz2 nhz2 marked this pull request as ready for review October 20, 2024 01:24
@nhz2 nhz2 marked this pull request as draft October 24, 2024 16:41
@fingolfin
Copy link
Member

This will help testing JuliaIO/BSDiff.jl#49

That PR is titled "Bump compat for CodecBzip2, TranscodingStreams, and SuffixArrays" so how exactly does changing this JLL help with testing that PR?

@nhz2
Copy link
Contributor Author

nhz2 commented Oct 24, 2024

BSDiff.jl uses CodecBzip2.jl and bsdiff_classic_jll for testing, but the latest version of CodecBzip2.jl requires Bzip2_jll 1.0.8 or later, while bsdiff_classic_jll currently needs exactly Bzip2_jll 1.0.6

@nhz2 nhz2 marked this pull request as ready for review October 25, 2024 01:07
@nhz2
Copy link
Contributor Author

nhz2 commented Oct 25, 2024

I added patches and copyright info from https://salsa.debian.org/debian/bsdiff/-/tree/debian/4.3-17

This is the latest version from Debian I can figure out how to compile. 4.3-18 includes some mmap code that doesn't compile.

@giordano giordano merged commit 5366e53 into JuliaPackaging:master Oct 25, 2024
18 checks passed
@nhz2 nhz2 deleted the patch-2 branch October 25, 2024 12:58
avik-pal pushed a commit to avik-pal/Yggdrasil that referenced this pull request Oct 25, 2024
@nhz2 @avik-pal
[bsdiff_classic] Update Bzip2 compat (JuliaPackaging#9648)
5e74721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhz2 @giordano @fingolfin