Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libCppInterOp: bump version to v0.1.4 #9325

Merged
merged 2 commits into from
Oct 2, 2024
Merged

libCppInterOp: bump version to v0.1.4 #9325

merged 2 commits into from
Oct 2, 2024

Conversation

Gnimuc
Copy link
Contributor

@Gnimuc Gnimuc commented Aug 28, 2024 •
edited
Loading

switch back to my repo temporally for a test

Upgrade to LLVM 18.

@Gnimuc Gnimuc marked this pull request as ready for review September 29, 2024 15:51
@Gnimuc
Copy link
Contributor Author

Gnimuc commented Sep 29, 2024 •
edited
Loading

@giordano

Now, I need a new release version for LLVM 18. Is it OK to merely bump the patch number? (looks like bumping the major version of a dependency doesn't violate semver.)

Gnimuc
Gnimuc commented Sep 29, 2024
View reviewed changes
L/libCppInterOp/build_tarballs.jl

# Collection of sources required to complete build
sources = [
GitSource("https://github.com/compiler-research/CppInterOp.git", "ecbffafe0016022e40b7dea6e7197ee062dde38f"),
GitSource("https://github.com/Gnimuc/CppInterOp.git", "8d79c1a0cafe5d2ff6c74afbcfbd1be320caa06b"),
Copy link
Contributor Author

@Gnimuc Gnimuc Sep 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be a bit longer to get things merged in the CppInterOp upstream, so I'd like to temporally switch back to the fork source.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this is compiler-research/CppInterOp#304?

Copy link
Contributor Author

@Gnimuc Gnimuc Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'd like to use that branch as the git source temporarily before it finally gets merged.

At the moment, I only need one new version for testing Julia1.12 with LLVM18.

giordano
giordano reviewed Oct 1, 2024
View reviewed changes
L/libCppInterOp/build_tarballs.jl

# Collection of sources required to complete build
sources = [
GitSource("https://github.com/compiler-research/CppInterOp.git", "ecbffafe0016022e40b7dea6e7197ee062dde38f"),
GitSource("https://github.com/Gnimuc/CppInterOp.git", "8d79c1a0cafe5d2ff6c74afbcfbd1be320caa06b"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this is compiler-research/CppInterOp#304?

L/libCppInterOp/bundled/patches/cmake.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to upstream these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no plan to upstream the cmake patch.

@giordano giordano merged commit 440fbfe into JuliaPackaging:master Oct 2, 2024
24 checks passed
@Gnimuc Gnimuc deleted the up-cppinterop branch October 2, 2024 13:28
avik-pal pushed a commit to avik-pal/Yggdrasil that referenced this pull request Oct 25, 2024
@Gnimuc @avik-pal
libCppInterOp: bump version to v0.1.4 (JuliaPackaging#9325)
ca4cbdb 
* libCppInterOp: bump version to v0.1.4

* libCppInterOp: upgrade to LLVM 18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gnimuc @giordano