Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force option to path macro #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sharanry
Copy link

Current API does not allow to us forcefully use the contents stored in the Path object regardless of whether the path exists or not. This PR enables such use.

It is especially useful when the path stored exists but does not have the right permissions.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #34 (bc53ecf) into main (73e64ae) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files           1        1           
  Lines          61       61           
=======================================
  Hits           56       56           
  Misses          5        5           
Files Coverage Δ
src/RelocatableFolders.jl 91.80% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MichaelHatherly
Copy link
Collaborator

It is especially useful when the path stored exists but does not have the right permissions.

Thanks @sharanry, would you mine expanding on this a bit further? What kind of situation is this coming up in?

And does it have any relation to #32 at all?

@sharanry
Copy link
Author

sharanry commented Oct 30, 2023

@MichaelHatherly

I do think #32 is related but the functionality it aims to add does not solve the scenario I am trying to solve.

For some context which has already been mentioned before, in #32 @fredrikekre mentions

packages that are Pkg.added (the package manager makes all files read only)

This is exactly the scenario I am trying to tackle through this PR. The files from packages which are added end up becoming read-only and become troublesome to work with. This PR enables us to have relaxed permissions as we make sure to use files stored within the Path object which end up getting regenerated during runtime in the scratch space with the read-write permissions.

I am of the opinion that we need to keep the permissions of the files captured by the Path object configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants