Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform check #238

Closed

Conversation

davidanthoff
Copy link

ping @staticfloat

This works around the missing platform specific dependencies of Pkg3 for now. I don't really know whether this is good enough and don't really know how to test this, so fingers crossed this might work.

@simonbyrne
Copy link
Contributor

My suggestion would be on non-OS X:

  1. have deps/build.jl do nothing (i.e. put the current code behind a Sys.isapple() check).
  2. make using Homebrew throw an error (so any uses of using Homebrew should first check the OS).

Also, see discussion on JuliaLang/Pkg.jl#165

@simonbyrne simonbyrne mentioned this pull request Jul 27, 2018
@staticfloat
Copy link
Member

Closing in favor of #239

@davidanthoff davidanthoff deleted the platform-check branch July 31, 2018 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants