-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hparams API #129
Add hparams API #129
Conversation
I am excited about this feature. |
c55ecee
to
3e4dac2
Compare
Signed-off-by: Jamie Mair <[email protected]>
Signed-off-by: Jamie Mair <[email protected]>
Signed-off-by: Jamie Mair <[email protected]>
Signed-off-by: Jamie Mair <[email protected]>
Signed-off-by: Jamie Mair <[email protected]>
Signed-off-by: Jamie Mair <[email protected]>
Signed-off-by: Jamie Mair <[email protected]>
Signed-off-by: Jamie Mair <[email protected]>
Signed-off-by: Jamie Mair <[email protected]>
3e4dac2
to
b8fbbb6
Compare
@oxinabox @nomadbl I have finished the feature. The way that dictionary was serialised was actually wrong in the protobuf code, so I made it match the output of tensorboardX now. Thankfully, this fixed the issue of only one parameter showing up. I have added some docs as well on how to use it, along with an example script. Should be simple enough as users should only really interact with Note, I also bumped the version of the package as well. Should be no breaking changes as this only adds functionality. |
There's some really great work here, kudos. |
This allows the key (hyperparameter name) to be much longer than 127 bytes.
Thanks!
I have opened an issue (JuliaIO/ProtoBuf.jl#233) and PR (JuliaIO/ProtoBuf.jl#234), but these would be breaking changes for any downstream users, so I think that there is a chance that they might not accept the changes - it may take a while for this to go anywhere.
As the added methods have strict types, only applying to the HParams plugin, how would you feel about merging these changes now, as any changes in ProtoBuf may take a while/not happen? I have added a unit test with what the exact serialisation and deserialisation should be, which will make it easier to transition to any upstream fixes while verifying that tensorboard can still parse the output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with the precautions you have added it is reasonable to merge this now.
Thanks for taking care of the Protobuf issue and PR as well!
I have added another suggestion and approved the PR. Merge as you see fit.
@nomadbl Thanks for the quick review and guidance. I'll updated from master and will merge as soon as the unit tests pass. |
@nomadbl I have realised that I don't actually have write access, I think someone else would need to merge the changes. Thanks :) |
Continues work from #77.
EDIT: This now works! Closes #87