Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run compiler tests in parallel for Pkg.test #56655

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KristofferC
Copy link
Member

Time parallel:

Test Summary: |   Pass  Broken   Total     Time
  Overall     | 548765      95  548860  1m47.6s

Time serial:

Test Summary: |   Pass  Broken   Total     Time
Compiler.jl   | 554392      95  554487  3m41.2s

on an M1.

@KristofferC KristofferC requested review from Keno and aviatesk November 22, 2024 12:07
using InteractiveUtils: @activate
if !isdefined(Main, :__custom_compiler_active)
Base.eval(Main, :(__custom_compiler_active=true))
@activate Compiler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only want to do this when run as a package, not when run from Base. I had used identify_package("Compiler") === nothing for this, since Base clears the package/load path, but any way to figure out how it's run is fine.


Base.runtests(["Compiler"]; propagate_project=true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

special_loading needs to be filtered

@Keno Keno force-pushed the kc/parallel_compiler branch from fcfacdc to 060495c Compare January 7, 2025 21:07
@Keno
Copy link
Member

Keno commented Jan 7, 2025

@KristofferC FYI, I rebased this for you to address some of the CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants